search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Modify resource_anl.json to support polaris machine on ANL. #2806

Closed GKNB closed 1 year ago

GKNB commented 1 year ago

Two new cases, polaris and polaris_interactive are added. These two are machines on ANL with pbspro rm. They are both tested with Tianle and Mikhail on polaris login node (for polaris) and polaris interactive node (for polaris_interactive).

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.86%. Comparing base (bc4f43e) to head (ea2c95d). Report is 3584 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #2806 +/- ## ======================================= Coverage 42.86% 42.86% ======================================= Files 83 83 Lines 9286 9286 ======================================= Hits 3980 3980 Misses 5306 5306 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtitov commented 1 year ago

Thanks, looks good to me. One question though: the used python presumably comes from module load conda. Should "python_dist": "anaconda" be set also, or is that not needed because of the pre-set VE?

that's correct about pre-set VE ("virtenv_mode" : "local") and following as it is for Theta (and especially if some MPI libs are needed then provided conda base env should be cloned, e.g., mpi4py is within that base env)