radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Fix/raptor worker sync #2819

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

This fixes #2813 and #2814

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 28.91566% with 295 lines in your changes missing coverage. Please review.

Project coverage is 43.73%. Comparing base (d1f695f) to head (c2c52be). Report is 3553 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/raptor/worker.py 41.12% 136 Missing :warning:
src/radical/pilot/raptor/master.py 2.24% 87 Missing :warning:
src/radical/pilot/raptor/worker_mpi.py 4.87% 39 Missing :warning:
src/radical/pilot/raptor/worker_default.py 4.16% 23 Missing :warning:
src/radical/pilot/agent/executing/flux.py 40.00% 3 Missing :warning:
src/radical/pilot/agent/agent_0.py 50.00% 2 Missing :warning:
src/radical/pilot/agent/executing/sleep.py 50.00% 2 Missing :warning:
src/radical/pilot/agent/executing/base.py 66.66% 1 Missing :warning:
src/radical/pilot/tmgr/scheduler/base.py 50.00% 1 Missing :warning:
src/radical/pilot/tmgr/staging_input/default.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #2819 +/- ## ========================================== + Coverage 42.88% 43.73% +0.85% ========================================== Files 83 83 Lines 9288 9187 -101 ========================================== + Hits 3983 4018 +35 + Misses 5305 5169 -136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AymenFJA commented 1 year ago

@andre-merzky:

(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$ python raptor.py
Traceback (most recent call last):
  File "raptor.py", line 47, in <module>
    @rp.pythontask
AttributeError: module 'radical.pilot' has no attribute 'pythontask'
(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$
andre-merzky commented 1 year ago

@andre-merzky:

(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$ python raptor.py
Traceback (most recent call last):
  File "raptor.py", line 47, in <module>
    @rp.pythontask
AttributeError: module 'radical.pilot' has no attribute 'pythontask'
(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$

I am afraid I cannot reproduce that:

(ve3)  $ rs

  python               : /mnt/home/merzky/radical/radical.pilot.work/ve3/bin/python3
  pythonpath           : 
  version              : 3.6.9
  virtualenv           : /mnt/home/merzky/radical/radical.pilot.work/ve3

  radical.gtod         : 1.16.0
  radical.pilot        : 1.20.1-v1.20.1-53-gd563304a0@fix-raptor_worker_sync
  radical.saga         : 1.20.0
  radical.utils        : 1.20.1

)ve3) $ python3 -c 'import radical.pilot as rp; print(rp.pythontask)'
<function PythonTask.pythontask at 0x7fec474dce18>

(ve3)  $ ./raptor.py 

================================================================================
 Raptor example (RP version 1.20.1)                                             
================================================================================

new session: [rp.session.rivendell.merzky.019379.0000]                         \
database   : [mongodb://localhost/am]                                         ok
create pilot manager                                                          ok
create task manager^Cclosing session rp.session.rivendell.merzky.019379.0000     \
close pilot manager                                                            \
wait for 0 pilot(s)
              0                                                               ok
[...]

Can you please provide more details or try to track it down?

AymenFJA commented 1 year ago

@andre-merzky:

(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$ python raptor.py
Traceback (most recent call last):
  File "raptor.py", line 47, in <module>
    @rp.pythontask
AttributeError: module 'radical.pilot' has no attribute 'pythontask'
(rct_dev) $:~/RADICAL/test_raptor/radical.pilot/examples/misc$

I am afraid I cannot reproduce that:

(ve3)  $ rs

  python               : /mnt/home/merzky/radical/radical.pilot.work/ve3/bin/python3
  pythonpath           : 
  version              : 3.6.9
  virtualenv           : /mnt/home/merzky/radical/radical.pilot.work/ve3

  radical.gtod         : 1.16.0
  radical.pilot        : 1.20.1-v1.20.1-53-gd563304a0@fix-raptor_worker_sync
  radical.saga         : 1.20.0
  radical.utils        : 1.20.1

)ve3) $ python3 -c 'import radical.pilot as rp; print(rp.pythontask)'
<function PythonTask.pythontask at 0x7fec474dce18>

(ve3)  $ ./raptor.py 

================================================================================
 Raptor example (RP version 1.20.1)                                             
================================================================================

new session: [rp.session.rivendell.merzky.019379.0000]                         \
database   : [mongodb://localhost/am]                                         ok
create pilot manager                                                          ok
create task manager^Cclosing session rp.session.rivendell.merzky.019379.0000     \
close pilot manager                                                            \
wait for 0 pilot(s)
              0                                                               ok
[...]

Can you please provide more details or try to track it down?

@andre-merzky my fault or (pip fault) for some reason, pip failed to install/ update the existing stack with fix-raptor_worker_sync.

Sorry for the noise.