radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Set `blocked_cores/gpus` part of `system_architecture` in resource config #2820

Closed mtitov closed 1 year ago

mtitov commented 1 year ago

Parameter system_architecture is provided to SAGA and its sub-parameter blocked_cores is used to define a core specialization (currently with focus on SLURM adaptor - RS PR #870)

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.88%. Comparing base (3590fef) to head (c9fcb84). Report is 3507 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #2820 +/- ## ======================================= Coverage 42.87% 42.88% ======================================= Files 83 83 Lines 9287 9288 +1 ======================================= + Hits 3982 3983 +1 Misses 5305 5305 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtitov commented 1 year ago

Andre, thank you! Along with your approval and before merging, I will test it on target machines.

I am not sure about the module load / unload related changes but assume you know what you are doing there :-)

yeah, that was part of the cleaning :) used these changes for the latest runs and moved it here while editing corresponding configurations

andre-merzky commented 1 year ago

I am not sure about the module load / unload related changes but assume you know what you are doing there :-)

yeah, that was part of the cleaning :) used these changes for the latest runs and moved it here while editing corresponding configurations

Sounds good, thanks for the context!

mtitov commented 1 year ago

tested on Crusher@OLCF (and confirmed changes on Summit@OLCF)