search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

fix task environment setup for raptor tasks #2890

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

Fixes #2889

This PR ensures that Raptor tasks run in the same environment as the Raptor workers, but augmented with the task description's environment dict and the RP_* env settings. The main fix is to invert the logic on the env copy in src/radical/pilot/raptor/worker.py line 99.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.17%. Comparing base (ff1fe28) to head (9af6b86). Report is 3345 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/raptor/worker.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #2890 +/- ## ========================================== - Coverage 40.18% 40.17% -0.01% ========================================== Files 94 94 Lines 10260 10262 +2 ========================================== Hits 4123 4123 - Misses 6137 6139 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eirrgang commented 1 year ago

Test job running at https://github.com/SCALE-MS/scale-ms/actions/runs/4628011576/jobs/8186580685?pr=328

eirrgang commented 1 year ago

I'm not 100% sure the environment is completely usable. I should probably address the remaining issue in my test, which I presume is related to the task sandbox issues.

eirrgang commented 1 year ago

I'm not 100% sure the environment is completely usable. I should probably address the remaining issue in my test, which I presume is related to the task sandbox issues.

I have a workaround in place for the task directories. It looks like we're good to go.