search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Docs/nb section3 debug #2934

Closed andre-merzky closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

andre-merzky commented 1 year ago

Ah, of course, that should have gone to the docs branch. Fixed.

andre-merzky commented 1 year ago

Please commit the notebook without executing the cells.

This was what we discussed on the last call: I did that because I wasn't sure if I should run a session or store a session, so I committed the cells to make it easier to review. I'll change that to running a session (likely not today though).

mturilli commented 1 year ago

Please commit the notebook without executing the cells.

This was what we discussed on the last call: I did that because I wasn't sure if I should run a session or store a session, so I committed the cells to make it easier to review. I'll change that to running a session (likely not today though).

I agree we discussed it on Friday but I believe we had agreed for you to:

  1. run a mini-RP script in a single cell without reporter
  2. (try to) use a variable to store the session ID
  3. Use something like ! to run example debug commands on the session sandbox(es)
andre-merzky commented 1 year ago

I agree we discussed it on Friday but I believe we had agreed for you to:

Yes, indeed - just did not do that yet...

mturilli commented 1 year ago

popen.py breaks the rank test.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2934 (8e96ebb) into devel (5bab736) will decrease coverage by 0.04%. The diff coverage is 16.66%.

@@            Coverage Diff             @@
##            devel    #2934      +/-   ##
==========================================
- Coverage   41.48%   41.44%   -0.04%     
==========================================
  Files          95       95              
  Lines       10476    10483       +7     
==========================================
- Hits         4346     4345       -1     
- Misses       6130     6138       +8
Impacted Files Coverage Δ
src/radical/pilot/pmgr/launching/base.py 46.30% <0.00%> (-0.70%) :arrow_down:
src/radical/pilot/agent/executing/popen.py 82.99% <100.00%> (-0.05%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more