search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Change in `virtenv` set-up may introduce undocumented breaking changes. #2951

Closed eirrgang closed 1 year ago

eirrgang commented 1 year ago

With rp 1.33, I've started to see a .env file created next to the pre-configured Python venv that I use. I don't know whether this is related to "virtenv_mode": "use", "virtenv": "/home/rp/rp-venv" in my resource definition or to something in the raptor or task set-up.

Anyway, is this expected behavior?

I think I've previously seen such files for venvs that RP creates, but not for existing venvs that it (re)uses.

Is the path for /home/rp/rp-venv.env chosen because it is in my home directory or because it is a modification of the venv path? I don't think there was previously an assumption that the parent directory of the virtual environment would be writable. This could cause problems in some environments.

It also appears that the file has session-specific information, which would introduce a restriction that a venv may only be used by one pilot at a time.

andre-merzky commented 1 year ago

This is indeed a problem - we track this already in #2930, thus closing this as duplicate if you don' t mind.