radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

AgentComponent to forward all state notifications #3088

Closed andre-merzky closed 10 months ago

andre-merzky commented 10 months ago

Fix forwarding of agent side state notifications. This fixes #3087

codecov[bot] commented 10 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0ab8fab) 43.99% compared to head (d9847bf) 44.00%. Report is 1 commits behind head on devel.

Files Patch % Lines
src/radical/pilot/raptor/master.py 33.33% 2 Missing :warning:
src/radical/pilot/utils/component.py 71.42% 2 Missing :warning:
src/radical/pilot/agent/agent_0.py 50.00% 1 Missing :warning:
src/radical/pilot/agent/agent_n.py 50.00% 1 Missing :warning:
src/radical/pilot/agent/executing/base.py 50.00% 1 Missing :warning:
src/radical/pilot/agent/scheduler/base.py 50.00% 1 Missing :warning:
src/radical/pilot/agent/staging_input/base.py 50.00% 1 Missing :warning:
src/radical/pilot/agent/staging_output/base.py 50.00% 1 Missing :warning:
src/radical/pilot/pilot_manager.py 50.00% 1 Missing :warning:
src/radical/pilot/pmgr/launching/base.py 50.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3088 +/- ## ======================================= Coverage 43.99% 44.00% ======================================= Files 96 96 Lines 10574 10577 +3 ======================================= + Hits 4652 4654 +2 - Misses 5922 5923 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andre-merzky commented 10 months ago

added one comment and have couple questions regarding rpu.Worker

* do we keep it for `Agent_0` and `Agent_N`?

* for `rp.worker.Stager`, should we switch to `ClientComponent`?

Yeah, we can probably get rid of the Worker class by now...

mtitov commented 10 months ago

as an intermediate testing - RP from this branch runs successfully on Lassen (tmgr.wait_tasks(uids=tasks_uids, state=rp.AGENT_EXECUTING) waits correctly)