search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

fix flux event management #3102

Closed andre-merzky closed 8 months ago

andre-merzky commented 9 months ago

This fixes #2837

codecov[bot] commented 9 months ago

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (7e72843) 44.22% compared to head (fd91244) 44.50%.

Files Patch % Lines
src/radical/pilot/agent/executing/flux.py 8.82% 31 Missing :warning:
src/radical/pilot/agent/scheduler/flux.py 0.00% 14 Missing :warning:
src/radical/pilot/utils/component.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3102 +/- ## ========================================== + Coverage 44.22% 44.50% +0.27% ========================================== Files 96 96 Lines 10615 10545 -70 ========================================== - Hits 4695 4693 -2 + Misses 5920 5852 -68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtitov commented 8 months ago

need to update requirements.txt -> radical.utils>=1.44 (and update saga as well -> >=1.40)

andre-merzky commented 8 months ago

need to update requirements.txt -> radical.utils>=1.44 (and update saga as well -> >=1.40)

Thanks, done

andre-merzky commented 8 months ago

The tests now fail for the missing radical.utils>=1.44 dependency - will get fixed once that is released.

andre-merzky commented 8 months ago

Tests are passing now...