fixed type for `LFS_SIZE_PER_NODE`

mtitov commented 8 months ago

caused this issue (RCT stack 1.46.0)

(ve) [matitov@login05.frontier pilot.0000]$ cat agent_0.err
Traceback (most recent call last):
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/bin/radical-pilot-agent_0", line 17, in <module>
    agent = rp.Agent_0()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/agent_0.py", line 47, in __init__
    self._session = Session(uid=cfg.sid, cfg=cfg, _role=Session._AGENT_0)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 191, in __init__
    elif self._role == self._AGENT_0: self._init_agent_0()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 287, in _init_agent_0
    self._init_rm()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 808, in _init_rm
    self._rm = ResourceManager.create(name=rname,
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/resource_manager/base.py", line 382, in create
    return rm(cfg, rcfg, log, prof)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/resource_manager/base.py", line 152, in __init__
    rm_info.verify()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 416, in verify
    self._data[k] = self._verify_kvt(k, v, self._schema[k])
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 396, in _verify_kvt
    if t in [str, int, float]  : return cls._verify_base(k, v, t)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 333, in _verify_base
    cls.__raise_type_error(k, v, t)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 322, in __raise_type_error
    raise TDTypeError(
radical.utils.typeddict.TDTypeError: RMInfo.verify - attribute "lfs_per_node" - expected type <class 'int'>, got <class 'str'>

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dfe20f5) 44.50% compared to head (404de41) 44.50%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## devel #3118 +/- ## ======================================= Coverage 44.50% 44.50% ======================================= Files 96 96 Lines 10545 10545 ======================================= Hits 4693 4693 Misses 5852 5852 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtitov commented 8 months ago

@andre-merzky should this be merged into master branch and released with 1.46.1?

radical-cybertools / radical.pilot

fixed type for `LFS_SIZE_PER_NODE` #3118

Codecov Report