radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

add sanity check on task ranks #3129

Closed andre-merzky closed 7 months ago

andre-merzky commented 7 months ago

This fixes #2655

codecov[bot] commented 7 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cb37d50) 44.52% compared to head (68b3a6f) 44.56%. Report is 4 commits behind head on devel.

:exclamation: Current head 68b3a6f differs from pull request most recent head a58aa46. Consider uploading reports for the commit a58aa46 to get more accurate results

Files Patch % Lines
src/radical/pilot/agent/scheduler/base.py 29.41% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3129 +/- ## ========================================== + Coverage 44.52% 44.56% +0.03% ========================================== Files 96 96 Lines 10544 10543 -1 ========================================== + Hits 4695 4698 +3 + Misses 5849 5845 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andre-merzky commented 7 months ago

Thanks for both comments - applied the changes!