disable env inheritance in PSIJ launcher

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 45.02%. Comparing base (a36a02b) to head (2d1cbbf).

Files	Patch %	Lines
src/radical/pilot/pmgr/launching/psi_j.py	0.00%	9 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## devel #3136 +/- ## ======================================= Coverage 45.02% 45.02% ======================================= Files 94 94 Lines 10261 10263 +2 ======================================= + Hits 4620 4621 +1 - Misses 5641 5642 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mturilli commented 6 months ago

Needs to take into account when inheritance is actually needed.

mtitov commented 6 months ago

Should be considered that disabling env inheritance is for the batch script, but it is recommended to reset it inside the execution environment, since corresponding launch methods might reuse (specifically the case for SBATCH and SRUN) options set by the batch script

Slurm example

...
#SBATCH --export  NONE

unset SLURM_EXPORT_ENV

References: OLCF user guide - link1, link2

andre-merzky commented 6 months ago

This should be ready for another review.

radical-cybertools / radical.pilot

disable env inheritance in PSIJ launcher #3136

Codecov Report