search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Hotfix/deployment #3169

Closed andre-merzky closed 7 months ago

andre-merzky commented 7 months ago

This PR removes code which handles sdist staging and installation into the agent space. Instead we rely on reusing the client side VE or install RP and dependencies via pip.

andre-merzky commented 7 months ago

Our rules don's seem to run tests when PR points to master, thus pointing to devel for now.

andre-merzky commented 7 months ago

@mtitov , @mturilli : this is ready for review now. The PR is a bit rough, a proper cleanup would need additional changes in RU. I'll leave that for the next sprint, this PR is just to get things going again.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.89%. Comparing base (cd588ef) to head (4bbcfbd). Report is 23 commits behind head on devel.

:exclamation: Current head 4bbcfbd differs from pull request most recent head cfa06a6. Consider uploading reports for the commit cfa06a6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3169 +/- ## ========================================== - Coverage 45.01% 44.89% -0.12% ========================================== Files 94 94 Lines 10266 10274 +8 ========================================== - Hits 4621 4613 -8 - Misses 5645 5661 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andre-merzky commented 7 months ago

Looks good to me. We can merge after Mikhail tests it on Frontier.

I tested on Frontier by now - merging.