search

radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

cleanup defaults for virtenv setup #3181

Closed mtitov closed 4 months ago

mtitov commented 4 months ago

Propose to have defaults in resource config so we reuse current [client] virtual environment and installed RP in it. And if VE should be [re]created that should be set explicitly within the config file.

p.s. I've also cleaned out constants from PMGRLaunching, since they are set within ResourceConfig

@andre-merzky if these changes are accepted, can we have it within the upcoming release?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.75%. Comparing base (0cdf636) to head (5c2ba78).

Files Patch % Lines
src/radical/pilot/pmgr/launching/base.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3181 +/- ## ========================================== - Coverage 44.77% 44.75% -0.03% ========================================== Files 94 94 Lines 10286 10278 -8 ========================================== - Hits 4606 4600 -6 + Misses 5680 5678 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB