search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

Update `n_nodes` handling #796

Closed mtitov closed 4 years ago

mtitov commented 4 years ago

@andre-merzky shouldn't we let slurm to raise an error if it would cause the issue? if some machine will fall into the option without n_nodes (and/or by default it might consider 1 node) and will use that memory_per_node/total_memory at --mem option, thus the restriction will be from our side (kinda ahead)

andre-merzky commented 4 years ago

Yeah, I see your point - but (a) errors from Slurm are harder to catch and to report, and (b) the SAGA spec requires to raise an error if a parameter is specified but cannot be interpreted.

mtitov commented 4 years ago

thanks @andre-merzky, that makes sense. Updated accordingly