fix sh timeout for long running sessions

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.

http://radical-cybertools.github.io/saga-python/

Other

83 stars 34 forks source link

fix sh timeout for long running sessions #811

Closed andre-merzky closed 3 years ago

andre-merzky commented 3 years ago

This adds an infrequent keepalive-ping between service instance and shell_wrapper so that the shell timeout does not kick in as long as the connection is up.

mtitov commented 3 years ago

@andre-merzky should this loop be wrapped with with self._shell_lock: as well? (similar to L723)

mtitov commented 3 years ago

btw to pass tests I had to clean up $HOME/.radical/saga (old wrapper wasn't rewritten)

andre-merzky commented 3 years ago

btw to pass tests I had to clean up $HOME/.radical/saga (old wrapper wasn't rewritten)

Hmm, probably not good, but I would like to keep that fix out of this PR...