Closed mtitov closed 3 years ago
Inside ShellJob there are several methods (get_stdout, get_stderr, get_log) that have a call self.js.shell.run_sync, should it be put into with self.js._shell_lock: construction?
ShellJob
get_stdout
get_stderr
get_log
self.js.shell.run_sync
with self.js._shell_lock:
Yes, they should, thanks for catching that! They would otherwise interfere with the ping thread (potentially).
ping
Inside
ShellJob
there are several methods (get_stdout
,get_stderr
,get_log
) that have a callself.js.shell.run_sync
, should it be put intowith self.js._shell_lock:
construction?