search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

Fix for ShellJob[Service] #812

Closed mtitov closed 3 years ago

mtitov commented 3 years ago

Inside ShellJob there are several methods (get_stdout, get_stderr, get_log) that have a call self.js.shell.run_sync, should it be put into with self.js._shell_lock: construction?

andre-merzky commented 3 years ago

Yes, they should, thanks for catching that! They would otherwise interfere with the ping thread (potentially).