search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

longhorn GRES exception #836

Closed lee212 closed 3 years ago

lee212 commented 3 years ago

To respond to #835 , GRES option is excluded from the Longhorn slurm script,

            if gpu_count: script += "#SBATCH --gpus=%s\n" % gpu_count

is eliminated when host is longhorn.

codecov[bot] commented 3 years ago

Codecov Report

Merging #836 (6ee1381) into devel (2e88d31) will increase coverage by 0.01%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #836      +/-   ##
==========================================
+ Coverage   42.78%   42.79%   +0.01%     
==========================================
  Files          97       97              
  Lines       12695    12697       +2     
==========================================
+ Hits         5431     5434       +3     
+ Misses       7264     7263       -1
Impacted Files Coverage Δ
src/radical/saga/adaptors/slurm/slurm_job.py 33.39% <50.00%> (+0.06%) :arrow_up:
src/radical/saga/utils/pty_process.py 71.50% <0.00%> (+0.28%) :arrow_up:
src/radical/saga/job/service.py 77.77% <0.00%> (+0.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e88d31...6ee1381. Read the comment docs.