search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

consistent use of radical_base #841

Closed andre-merzky closed 2 years ago

andre-merzky commented 2 years ago

This PR removes remnants of $HOME/.radical throughout the code base and consistently uses $RADICAL_BASE/.radical instead. Fixes #838

codecov[bot] commented 2 years ago

Codecov Report

Merging #841 (671dd95) into devel (6078f7c) will decrease coverage by 0.01%. The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #841      +/-   ##
==========================================
- Coverage   42.77%   42.76%   -0.02%     
==========================================
  Files          97       97              
  Lines       12703    12702       -1     
==========================================
- Hits         5434     5432       -2     
- Misses       7269     7270       +1
Impacted Files Coverage Δ
src/radical/saga/adaptors/loadl/loadljob.py 17.18% <0.00%> (-0.04%) :arrow_down:
src/radical/saga/adaptors/context/myproxy.py 42.25% <33.33%> (+1.40%) :arrow_up:
src/radical/saga/adaptors/cobalt/cobaltjob.py 31.14% <66.66%> (ø)
src/radical/saga/adaptors/shell/shell_job.py 61.01% <66.66%> (ø)
src/radical/saga/utils/pty_shell.py 60.19% <66.66%> (-0.44%) :arrow_down:
src/radical/saga/adaptors/sge/sgejob.py 18.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6078f7c...671dd95. Read the comment docs.

andre-merzky commented 2 years ago

Thanks for cleaning this up! :-) Added a comment though...

andre-merzky commented 2 years ago

Merge will wait for feedback on #838 to confirm this does the expected for @CalmingBreeze