radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

Fix/slurm spock #848

Closed andre-merzky closed 2 years ago

andre-merzky commented 2 years ago

Should this be merged?

codecov[bot] commented 2 years ago

Codecov Report

Merging #848 (9052778) into devel (c0e5516) will decrease coverage by 0.00%. The diff coverage is 14.28%.

@@            Coverage Diff             @@
##            devel     #848      +/-   ##
==========================================
- Coverage   42.85%   42.85%   -0.01%     
==========================================
  Files          97       97              
  Lines       12749    12738      -11     
==========================================
- Hits         5464     5459       -5     
+ Misses       7285     7279       -6     
Impacted Files Coverage Δ
src/radical/saga/adaptors/slurm/slurm_job.py 35.88% <14.28%> (-0.11%) :arrow_down:
src/radical/saga/job/service.py 76.92% <0.00%> (-0.86%) :arrow_down:
src/radical/saga/utils/misc.py 48.30% <0.00%> (+1.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0e5516...9052778. Read the comment docs.