search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

SAGA.Exception should not overwrite representation #857

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

The SAGA exception overwriting the repr and str methods makes it impossible to programmatically inspect the raised exception. They are also against Python conventions, so this PR removes them - SAGA now (correctly) relies on the Exception base class to do the right thing...

codecov[bot] commented 1 year ago

Codecov Report

Merging #857 (da612ed) into devel (e7aaf81) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #857      +/-   ##
==========================================
- Coverage   42.86%   42.86%   -0.01%     
==========================================
  Files          97       97              
  Lines       12745    12741       -4     
==========================================
- Hits         5463     5461       -2     
+ Misses       7282     7280       -2
Impacted Files Coverage Δ
src/radical/saga/exceptions.py 66.66% <ø> (-0.23%) :arrow_down:
src/radical/saga/job/service.py 77.77% <0.00%> (+0.85%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more