search

radical-cybertools / radical.saga

A Light-Weight Access Layer for Distributed Computing Infrastructure and Reference Implementation of the SAGA Python Language Bindings.
http://radical-cybertools.github.io/saga-python/
Other
83 stars 34 forks source link

fixed option(s) for PBSPro tool(s) #878

Closed mtitov closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #878 (4088cb1) into devel (0e4c0a1) will increase coverage by 0.00%. The diff coverage is 25.00%.

@@           Coverage Diff           @@
##            devel     #878   +/-   ##
=======================================
  Coverage   43.39%   43.40%           
=======================================
  Files          97       97           
  Lines       12736    12734    -2     
=======================================
  Hits         5527     5527           
+ Misses       7209     7207    -2
Impacted Files Coverage Δ
src/radical/saga/adaptors/slurm/slurm_job.py 37.25% <0.00%> (ø)
src/radical/saga/adaptors/pbspro/pbsprojob.py 28.39% <28.57%> (+0.11%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mtitov commented 1 year ago

I know there aren't many PBSPro hosts left - but are we sure we don't have any where the -f1 flag would still be needed?

yeah! -fx covers all cases (I actually didn't find any example with -f1)