radical-cybertools / radical.utils

Utility classes and tools for various radical projects
Other
8 stars 6 forks source link

Feature/no rmq #366

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

This accompanies https://github.com/radical-cybertools/radical.entk/pull/626. The main purpose is to make sure that the ZMQ bridge embedded in RE stores logfiles in the session sandbox.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | d9e981279969c590d53ea5d26bc157c3b0f78246 | src/radical/utils/zmq/bridge.py | [View secret](https://github.com/radical-cybertools/radical.utils/commit/d9e981279969c590d53ea5d26bc157c3b0f78246#diff-66828807a65bdb9839cfc199aade19f1R40) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | d9e981279969c590d53ea5d26bc157c3b0f78246 | src/radical/utils/zmq/bridge.py | [View secret](https://github.com/radical-cybertools/radical.utils/commit/d9e981279969c590d53ea5d26bc157c3b0f78246#diff-66828807a65bdb9839cfc199aade19f1L40) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | b8ac7bd83437a09164369d67ef717f0d0edd0820 | src/radical/utils/zmq/bridge.py | [View secret](https://github.com/radical-cybertools/radical.utils/commit/b8ac7bd83437a09164369d67ef717f0d0edd0820#diff-66828807a65bdb9839cfc199aade19f1R45) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | b8ac7bd83437a09164369d67ef717f0d0edd0820 | src/radical/utils/zmq/bridge.py | [View secret](https://github.com/radical-cybertools/radical.utils/commit/b8ac7bd83437a09164369d67ef717f0d0edd0820#diff-66828807a65bdb9839cfc199aade19f1L45) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.40%. Comparing base (ae0dd9b) to head (de60589). Report is 366 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #366 +/- ## ======================================= Coverage 61.39% 61.40% ======================================= Files 60 60 Lines 6712 6713 +1 ======================================= + Hits 4121 4122 +1 Misses 2591 2591 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.