search

radical-cybertools / radical.utils

Utility classes and tools for various radical projects
Other
8 stars 6 forks source link

remove invalid strip #382

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

The removed strip sometimes removed significant whitespace (e.g., for VE promp variables).

codecov[bot] commented 1 year ago

Codecov Report

Merging #382 (f976268) into devel (e011715) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            devel     #382   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          60       60           
  Lines        6721     6721           
=======================================
  Hits         4131     4131           
  Misses       2590     2590
Impacted Files Coverage Δ
src/radical/utils/env.py 61.24% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mtitov commented 1 year ago

@andre-merzky there are also strips in env_eval (for values), that should be updated as well, right?

andre-merzky commented 1 year ago

@andre-merzky there are also strips in env_eval (for values), that should be updated as well, right?

I think those are fine actually - those spaces should not be significant. At least they did not trip the tests in the way the fixed one did :-)