search

radicaled / dart-tools

Various tools for Dart in Atom
MIT License
23 stars 3 forks source link

Linter exception while using dart-tools #98

Closed alechenninger closed 9 years ago

alechenninger commented 9 years ago

Please see https://github.com/AtomLinter/Linter/issues/713

Not sure if this is issue with dart-tools and/or linter, but linter works fine for non-dart projects.

radicaled commented 9 years ago

Looks like a regression on their side.

alechenninger commented 9 years ago

Yeah I think you're right, thanks for quick response

radicaled commented 9 years ago

Gonna leave this open so incoming users will know it's broken.

alechenninger commented 9 years ago

Ack, cool. I downgraded linter to 1.1.0 and no issues.

devoncarew commented 9 years ago

I suspect they changed their API for the linter:

https://github.com/AtomLinter/Linter/blob/a292cd757489d6a3ddc70a7e03c5d127e285b587/lib/linter-plus.coffee#L90

radicaled commented 9 years ago

It's the line below that: they're referencing a non-existent variable.

radicaled commented 9 years ago

Someone fudged a refactor, in other words.

radicaled commented 9 years ago

@alechenninger grab the newest dart-tools and it should be fixed. I've gone ahead and quickly upgraded to their working API

alechenninger commented 9 years ago

Thanks! With the latest version of linter and dart-tools running the analyzer works fine with no exceptions. :+1:

radicaled commented 9 years ago

Great! Now I'll close the issue. :)