search

radicallyopensecurity / pentext

PenText system: Easily create beautifully looking penetration test quotes, reports, and documents in many formats (PDF, text, JSON, CSV, ...)
GNU General Public License v2.0
117 stars 38 forks source link

Validating multiple masters files masks results #46

Closed gronke closed 2 years ago

gronke commented 7 years ago

The validate_files method creates a list of masters, which is a list of top-level .xml files.

When multiple of those files were detected, only the last one is taken into account for the results, as seen here https://github.com/radicallyopensecurity/pentext/blob/master/chatops/python/validate_report.py#L218-219

PeterMosmans commented 7 years ago

Thanks for reporting, I'll add an OR selector for the result

PeterMosmans commented 7 years ago

On second look, it seems to be working ? The result is okay when True. For the result a boolean AND statement is used, so the result will only be True if all validations were successful. Isn't this working as planned ? If not, could you please show / tell me an example how this would fail ?

Thanks!

Peter

PeterMosmans commented 7 years ago

@gronke is this still applicable ? If not, I'll close this report. Thanks for letting me know !

gronke commented 6 years ago

@PeterMosmans yes it is. Here's a permalink to the current master: https://github.com/radicallyopensecurity/pentext/blob/cf74247f868575591f083ea13948f3400b83f7a4/chatops/python/validate_report.py#L215=L216

PeterMosmans commented 6 years ago

Hi @gronke I'm a bit confused, as this seems to be working okay. The result (validation) is OK (true) if all validations were successful. If one fails along the way, then the result will be false. Am I missing something here ?

syrosh commented 2 years ago

Closing as file no longer exists