search

radicallyopensecurity / pentext

PenText system: Easily create beautifully looking penetration test quotes, reports, and documents in many formats (PDF, text, JSON, CSV, ...)
GNU General Public License v2.0
117 stars 38 forks source link

Allow finding_count to use (multiple) status attribute values #72

Closed PeterMosmans closed 5 years ago

PeterMosmans commented 5 years ago

This PR allows the use of multiple status attributes, when using the finding_count element without any other attributes.

Example:

<finding_count status="unresolved resolved not_retested" />
skyanth commented 5 years ago

Good but incomplete: the @status attribute in finding_count is not yet allowed by the schema and should be added there as well (pentestreport.xsd, line 415):

<xs:element name="finding_count">
     <xs:complexType>
          <xs:attribute ref="threatLevel" use="optional"/>
          <xs:attribute ref="status" use="optional"/>
     </xs:complexType>
</xs:element>

We don't want to make the life of people who actually validate their doc any harder... ;)

skyanth commented 5 years ago

(note: I should've added that bit to the schema back when I developed it, not your fault of course :D )

PeterMosmans commented 5 years ago

Hi @skyanth - see added commit ;) If okay, could you please merge it after reviewing? Thanks!