Closed rak3rman closed 8 months ago
Marking as "won't fix" since getting Postgres configured on the command line on Windows is more trouble than it's worth. However, three tasks still remain that should be opened as new issue(s):
.github/workflows/hono_integration.yml
workflow or create a new workflow to run all smoke tests on Linux and MacOS in a Matrix form only when files in shafa/hono/test/utils/*
are updated/committed to
Discussed in https://github.com/radicalplatforms/shafa/discussions/114
Description
Ah, this is (partially) intended behavior of the test utility that provisions the Postgres database locally. In this case, I wasn't able to test these scripts against a Windows machine (I use Mac and Ubuntu for development) so the script intentionally throws a fatal error if it detects a Windows environment.
Running on Windows will require an addition to the
getInstallationScript()
function located inshafa/hono/test/utils/db.ts
. I'll go ahead and open a new issue requesting this implementation.https://github.com/radicalplatforms/shafa/blob/main/hono/test/utils/db.ts#L98
Originally posted by @rak3rman in https://github.com/radicalplatforms/shafa/discussions/114#discussioncomment-8753394
getInstallationScript()
inshafa/hono/test/utils/db.ts
to support Postgres provisioning and startup in Windows environmentsgetCreateDbScript()
inshafa/hono/test/utils/db.ts
to support Postgres database creation in Windows environmentsgetStopScript()
inshafa/hono/test/utils/db.ts
to support Postgres teardown in Windows environments.github/workflows/hono_integration.yml
workflow or create a new workflow to run all smoke tests on Linux and Windows and MacOS in a Matrix form only when files inshafa/hono/test/utils/*
are updated/committed toAcceptance Criteria
getInstallationScript()
function inshafa/hono/test/utils/db.ts
is modified to support Postgres provisioning and startup in Windows environments.github/workflows/hono_integration.yml
workflow should be modified (or a new workflow created) to run all smoke tests on Linux, Windows, and MacOS in a Matrix form when files inshafa/hono/test/utils/*
are updated/committed to