radicalplatforms / shafa

A wardrobe logging, composition, and organization app
https://shafa.app
Mozilla Public License 2.0
1 stars 0 forks source link

Support for Windows Postgres provisioning on hono test cases #115

Closed rak3rman closed 8 months ago

rak3rman commented 8 months ago

Discussed in https://github.com/radicalplatforms/shafa/discussions/114

Originally posted by **vincentdo1** March 11, 2024 This is the error I get after installing packages and postgres 16. Was wondering if there is a work around for windows. ![image](https://github.com/radicalplatforms/shafa/assets/85699604/c337fc04-8f7a-4369-886b-c441eb7fe3c3)

Description

Ah, this is (partially) intended behavior of the test utility that provisions the Postgres database locally. In this case, I wasn't able to test these scripts against a Windows machine (I use Mac and Ubuntu for development) so the script intentionally throws a fatal error if it detects a Windows environment.

Running on Windows will require an addition to the getInstallationScript() function located in shafa/hono/test/utils/db.ts. I'll go ahead and open a new issue requesting this implementation.

https://github.com/radicalplatforms/shafa/blob/main/hono/test/utils/db.ts#L98

Originally posted by @rak3rman in https://github.com/radicalplatforms/shafa/discussions/114#discussioncomment-8753394

Acceptance Criteria

Generated by Zenhub AI

rak3rman commented 8 months ago

Marking as "won't fix" since getting Postgres configured on the command line on Windows is more trouble than it's worth. However, three tasks still remain that should be opened as new issue(s):