Getting site ready for Term 2 in Sprint 2017 (Brother Jim)

[radicalray]

Some Thoughts on ToE Online Site Improvements

• [x] Auto-forward to next page if already logged in.
• [x] Added username/logout to header to hold state across all pages.
• [x] On the home page, change the registration dates to those for 2017.
• [x] On the home page, remove the “NEW” crawler.
• [x] On the home page, change the statement about open registration from “first” term to “second” term.
• [ ] Make first/second term a single variable that's easier to change in the future.
• [x] Consolidate header/navigation pages
• [ ] Consolidate all the dates.
• [x] On the home page, change the training date information for the 2017 second term, and the training location to Newton, MA.
• [x] When you select the Media menu item, and any submenu item from the dropdown list, and subsequently fail the login, there is no pathway back to the home page (i.e., to the existing Go button add a Cancel button that will take you back to the home page).
• [x] Registration->New Registration, review the payment instructions and revise the text accordingly.
• [x] Study Group->Submit Group Info, there is no provision to cancel the operation and return to the home page.
• [x] For Local Administrators->List and Approve Trainees, when you click the Edit link, the form that is brought up still shows a registration fee of $100 (it’s $60) at the bottom of the form.
• [x] For Local Administrators->Attendance, the attendance matrix title should be Plenary Session Attendance rather than Trainee Attendance.
• [ ] General navigational dead ends, inconsistencies, and detours. Review and correct.
• [x] Study Group->Submit Group Info, review form fields. Do we need to enter the number of group members? Can’t software just count the number of names entered? How useful are the group meeting time, day, place fields? For many groups they vary.
• [x] Make the interplay between the study group reports and the study group attendance more seamless by eliminating duplicate manual effort to record attendance. Depending on thesolution adopted, this may require that there be a provision to record whether an absence is excused or unexcused on the study group report. It may also require that the names of brothers recorded be strictly controlled (no free form).
• [x] Consider defining a super-administrator role so that reports and statistics can be obtained across locality boundaries.
• [x] What happens if someone clicks the Submit button more than once on the New Registration application form? Can we screen out duplicates?
• [ ] Is it possible to auto-fill some of the fields of the study group report by keying off reporting brother or group number?

[radicalray]

@Brother Jim + @stevo49, I made as many modifications as I could without supervision (the items I checked). I need more information for the rest of the items.

Here are some items:

• Let's make the site dynamically change the term / dates depending on the time of the calendar? Please provide more specific dates so we can code this in.

• @sbruso how to re-enable registration?

• Can't really count names, have to require comma or space separators and people screw up.

  • Can make some fields optional?

• What does this mean? by keying off reporting brother or group number?

• Not sure what this means, couldn't find title: Plenary Session Attendance rather than Trainee Attendance.

[radicalray]

@stevo49 It seems that the ability to register admins page is missing?

http://localhost:8888/portal/admin/adminregister.php

Was it deleted or is another file? Thanks!

[radicalray]

This item is not possible b/c the information is not in the db for administrators:

• Is it possible to auto-fill some of the fields of the study group report by keying off reporting brother or group number?

Note about this item:

• What happens if someone clicks the Submit button more than once on the New Registration application form? Can we screen out duplicates?

User cannot submit more than 1 application with same email, however they can submit multiple ones if they change their email address each time since it's the only way we can guarantee it's not another user with the same name.

[radicalray]

• [x] double banner on media access page
• [x] adminregister.php file is missing
• [x] not track portal/uploads
• [x] Use this to populate group assignments. Figure out a way to show all trainees and add to specific group.
• [x] setup production git pull
• [x] Change production db schema constraints.

[radicalray]

• Re-registration

[jrdanker]

• [x] If you pull up a study group report (For Local Administrators->Review Study Group Report), then view the report (click VIEW in VIEW/EDIT/DELETE for the report), it still displays "2016 Canada Training on Eldership" in the report title.

• [x] If you pull up an accounting report (For Local Administrators->Accounting), the page still displays "2016 Canada Training on Eldership" in the title.

  • [x] If you pull up a study group report (For Local Administrators->Review Study Group Report), then view the report (click EDIT in VIEW/EDIT/DELETE for the report), change a field in the report (e.g., the lesson number), then click the Edit Study Report button (at the bottom) to submit the revised report, you get a HTTP 404 error.

• [x] If you request a Study Group Meeting Attendance Tracking report (For Local Administrators->Attendance, then click Here under 1 in the Study Group Meeting Attendance Tracking box), the table column header labes should read "Lesson 19"..."Lesson 36" that is they should reflect Term 2 lesson numbers (19-36). NOTE: change the word Session to Lesson.

  • [x] If you request a Study Group Meeting Attendance Tracking report (For Local Administrators->Attendance, then click Here under 1 in the Study Group Meeting Attendance Tracking box), in the blue highlighted attendance codes header, the phrase "Excused Absense" should read "Excused Absence" (i.e, a "c" not an "s"), and inside the same highlighted header add the sentence "Please do not record lesson viewing attendance; only lesson study sessions." in bold red letters.
  • [x] If you request a Plenary Session Attendance report (For Local Administrators->Attendance, then click Here under 1 in the Plenary Session Attendance box), the session dates listed in the header are the old Term 1 dates. They should be replaced with the Term 2 dates.

• [x] If you request a Plenary Session Attendance report (For Local Administrators->Attendance, then click Here under 2 in the Plenary Session Attendance box to mark the rest of the attendees present), several changes are needed: (a) the page still displays "2016 Canada Training on Eldership" in the title (b) the old Term 1 plenary session dates show in the drop down list for training dates; it should give the new 2nd Term plenary session dates (c) the phrase "Training Meeting Update Attendance Form" in the title should read "Plenary Session Update Attendance Form" (d) the phrase "The script will set the Monthly Training Attendance table..." to "The script will set the Plenary Session Training Attendance table..." (e) the pull-down list annotation that reads "Please enter the training date for the update:" should read "Please enter the Plenary Session date for the update:"

• [x] If you pull up a study group information summary (For Local Administrators->Review Study Group Info), the information in the Member IDs field shows record IDs not member names. Is this purposeful? I don't think the field label was Member IDs in the previous version. We should display names.

• [ ] If you pull up a study group information summary (For Local Administrators->Review Study Group Info), then view the report (click EDIT in VIEW/EDIT/DELETE for the report), the Number of Group Members and Members' Names fields in the form are blank. They should contain the info. On second thought, perhaps what should be shown is the list of names of the registered brothers (as is shown when you create the study group (Study Group->Submit Group Info), with the current members names checked, then the user can either check new names (if he wants to add) or uncheck the names of any current group members he wants to delete.

  • [ ] If you pull up a study group report (For Local Administrators->Review Study Group Report), then view the report (click VIEW in VIEW/EDIT/DELETE for the report), it shows record ID numbers instead of names in the attendees and absentees fields of the report form. It should display the names, not meaningless record numbers. NOTE: this is true only for reports filed using the latest production version release.

[radicalray]

@jrdanker Are these the term 2 dates?

Jan 28, Mar 11, Apr 15, May 20, Jun 24, Aug 19?

[jrdanker]

That is correct!

  From: Ray Li <notifications@github.com>

To: radicalray/brothers-training brothers-training@noreply.github.com Cc: jrdanker jrdanker@yahoo.com; Mention mention@noreply.github.com Sent: Thursday, January 12, 2017 1:44 AM Subject: Re: [radicalray/brothers-training] Site Update (Brother Jim) (#1)

@jrdanker Are these the term 2 dates?Jan 28, Mar 11, Apr 15, May 20, Jun 24, Aug 19?— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jrdanker]

• [x] The training registration fee has been reduced from $60 to $50 for this term. Can this be a named const and this name used wherever the fee is mentioned? If not a named const (just trying to look ahead), then at least edit the code to make the change wherever it appears.

[jrdanker]

• [x] I think I understand what you did with training registration. Of course, you added the renewal option, and, as far as the form is concerned, it looks good. In the top of the home page menu, under Registration, you changed the submenu item to Renew Application. I think it should be Submit Registration. If selected, it would bring up the same form (the renewal form), which has the option of being switched to the full form for a first time registration. I'm open for discussion.

[jrdanker]

The study group attendance matrix looks good with the header revisions. Could you bold the red lettered text under the attendance codes in the blue highlighted banner to make it stand out more?

[jrdanker]

• [x] If you use the option to set the rest of the trainees' attendance to "Present" for either the plenary sessions or the study group sessions (For Local Administrators->Attendance, then click Here under 2 in either the Plenary Session Attendance or the Study Group Meeting Attendance box to mark the rest of the attendees present, some of the trainees names are not marked in the corresponding attendance array (e.g., for Cambridge: Jeffrey Yu, Henry Hwang, Caleb Wang, Jifa Qi, etc.). It appears to be the same brothers for either the plenary or study group attendance arrays. NOTE: This is only for Cambridge; I have no way to examine the same phenomenon for other localities. I don't know why select brothers would be missed. I assume you are using a FOR EACH loop or something like it to step through the records. BTW, the same brothers names are omitted (i.e., attendance not marked) regardless of the lesson chosen.

[jrdanker]

Thanks, Ray for your all your hard work thus far. Things are looking much better! QA over and out for now. Perhaps we can talk more tonight.

[radicalray]

@jrdanker @stevo49 I finally figured out the reason for the bug above ^. The reason why some trainees (Jeffrey Yu) didn't get marked is b/c in the database for the column first_term, they're marked as 0 so they're not "technically" a registered/active trainee. I noticed there were tons of trainees in this category but I didn't know who should be marked and who shouldn't. @stevo49 could you fix this in the db? After that, the bug should go away. :)