search

radicle-dev / radicle-bins

Collection of radicle binaries.
Other
21 stars 9 forks source link

Output logs in GCP-compatible format #119

Closed adaszko closed 3 years ago

adaszko commented 3 years ago

This should allow for setting simple alerts, filtering by log level, etc.

kim commented 3 years ago

In addition to feature-gating the dependency, could we also have a runtime configuration which selects this format?

adaszko commented 3 years ago

In addition to feature-gating the dependency, could we also have a runtime configuration which selects this format?

Added a --gcp CLI switch for that purpose. Hope that's what you meant.

kim commented 3 years ago

Yeah that works, although it requires a breaking change in case yet another log format needs to be supported. I'll leave the call to @xla, @cloudhead, @FintanH

cloudhead commented 3 years ago

Indeed - can we do something like --log-format=gcp? Defaults to --log-format=plain.

adaszko commented 3 years ago

Indeed - can we do something like --log-format=gcp? Defaults to --log-format=plain.

Good point with the backward compatibility. It's done.