search

radicle-dev / radicle-git

Everything Radicle growing around Git
Other
35 stars 5 forks source link

radicle-surf: fix history path filter for empty path #104

Closed keepsimple1 closed 1 year ago

keepsimple1 commented 1 year ago

This is to solve issue #103 .

To add a new test case for this, I created a new empty-branch with an empty commit for git-platinum repo. And also added a script to update git-platinum data (.tgz file) in radicle-surf. The script is ported from the original radicle-surf repo.

Also, fix the CI linter to use Rust 1.66.1 for now because the new Rust 1.67.0 triggers many lint errors. We can have a separate PR to move the code to Rust 1.67.0.

xphoniex commented 1 year ago

why are you pushing to your own fork? aren't you a member of radicle-dev?

keepsimple1 commented 1 year ago

why are you pushing to your own fork? aren't you a member of radicle-dev?

Earlier on, I didn't have permissions to push directly to this repo. Now I'm already used to push to my fork for a PR. I can try to push directly in future. Is that a blocker?

xphoniex commented 1 year ago

why are you pushing to your own fork? aren't you a member of radicle-dev?

Earlier on, I didn't have permissions to push directly to this repo. Now I'm already used to push to my fork for a PR. I can try to push directly in future. Is that a blocker?

Yes, I'd appreciate if you push directly on radicle-dev. Thank you.

Make sure you prefix your branch name with your handle, like everyone else.

keepsimple1 commented 1 year ago

Yes, I'd appreciate if you push directly on radicle-dev. Thank you.

Will do in the next PR. Thanks for your review!