radicle-surf: refactoring EofNewLine

radicle-dev / radicle-git

Everything Radicle growing around Git

Other

41 stars 5 forks source link

Closed keepsimple1 closed 1 year ago

keepsimple1 commented 1 year ago

This is to solve issue #108 .

Moved eof into DiffContent::Plain as it only makes sense to plain text diffs. This changes the serialization of Diff and DiffContent but it's limited to only eof element.
Added a variant in EofNewLine enum: NoneMissing that is used when both the old file and the new file have a EOF new line, or for a newly Added file etc.

cloudhead commented 1 year ago

cc @xphoniex any changes needed on httpd?

xphoniex commented 1 year ago

cc @xphoniex any changes needed on httpd?

eof tests live here in surf, and they seem to be returning what is expected of them, also updated the methods for the disabled ones.

as for updating surf for httpd, needs more work, currently working on it.