git-commit: remove useless check in to_string()

radicle-dev / radicle-git

Everything Radicle growing around Git

Other

35 stars 5 forks source link

git-commit: remove useless check in to_string() #115

Closed keepsimple1 closed 1 year ago

keepsimple1 commented 1 year ago

This diff is triggered by a test failure in PR https://github.com/radicle-dev/heartwood/pull/280 .

~~However, it is not clear to me what exactly format we want for a commit. I'm adding some comments in the code.~~

This diff morphs into a simple refactoring for a check that I think is useless.

keepsimple1 commented 1 year ago

After looking at failed tests and the to_string() output, I think this diff is probably not necessary. But I think it's worth to discuss what we want to do going forward.