search

radicle-dev / radicle-git

Everything Radicle growing around Git
Other
41 stars 5 forks source link

git-commit: refactor trailers: remove git-trailers depedency. #116

Closed keepsimple1 closed 1 year ago

keepsimple1 commented 1 year ago

This patch is to take a stab at one area in issue #114 : simplify or remove git-trailers as a dependency crate.

Includes a new method trailers_of_key() that can potentially replace this file. (See test case)

keepsimple1 commented 1 year ago

If we're going to get rid of the git-trailers code then I think the git2 function should be used.

I looked at git2 functions but did not use them because they kept the message as is, i.e. not separating them. I'm OK with using git2 function if we keep the original message, or separate the message later.

FintanH commented 1 year ago

If we're going to get rid of the git-trailers code then I think the git2 function should be used.

I looked at git2 functions but did not use them because they kept the message as is, i.e. not separating them. I'm OK with using git2 function if we keep the original message, or separate the message later.

Ya, I remove the trailers in #117 while also using the git2 functionality. Are you happy to close this and we improve on #117 if needed?

keepsimple1 commented 1 year ago

Are you happy to close this and we improve on #117 if needed?

Yes, no problem. Closing this one now.