search

radicle-dev / radicle-git

Everything Radicle growing around Git
Other
41 stars 5 forks source link

git-commit: remove dependency on git-trailers #117

Closed FintanH closed 1 year ago

FintanH commented 1 year ago

Supersedes #116, as it uses git2's functionality for parsing commit trailers.

The git-trailers crate depends on parsing logic using nom. This is a heavy dependency for something that can be done using git2.

Remove the dependency of git-trailers in git-commit and localise the trailer types -- using git2 to parse the trailers out of the git commit message.

cloudhead commented 1 year ago

Looking good. Should we include a test?

FintanH commented 1 year ago

Regarding the questions about tests, I believe these should suffice. It covers the cases of no, one, and two trailers :)