radicle-dev / radicle-git

Everything Radicle growing around Git
Other
41 stars 5 forks source link

radicle-surf: consolidate `Commit` types #52

Closed FintanH closed 1 year ago

FintanH commented 1 year ago

Currently, we have 3 types of Commits that are being worked with in radicle-surf:

I think this can result in confusing semantics within some of the code. For example, I noticed in a few places that we may have a git::Commit just to go fetch a git2::Commit.

I think we should: a) Try to consolidate the two surf-defined Commits into a single type if possible b) Audit the code for this kind of extra trips to the repository and clean them up

keepsimple1 commented 1 year ago

I've created a PR to consolidate object::Commit and Commit. The git2::Commit is already hidden from the public API (if leaked, would be a bug).

keepsimple1 commented 1 year ago

done.