radicle-dev / radicle-git

Everything Radicle growing around Git
Other
41 stars 5 forks source link

`qualified!` macro requires `Qualified` in scope #54

Closed cloudhead closed 1 year ago

cloudhead commented 1 year ago

It seems like you can't invoke the qualified! macro without manually importing Qualified. I think it's because in the macro, we don't use a fully-qualified path: https://github.com/radicle-dev/radicle-git/blob/4f6284caf589fd7bda312fa1452a0976d5adb8a2/git-ref-format/macro/src/lib.rs#L62

I suspect component! may have the same issue looking at the code.

FintanH commented 1 year ago

The culprit is actually not importing Qualified here:

https://github.com/radicle-dev/radicle-git/blob/main/git-ref-format/macro/src/lib.rs#L69