search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

replication: Surface errors #603

Closed xla closed 3 years ago

xla commented 3 years ago

Don't swallow to give more context when fetch and sign errors occur.

Signed-off-by: Alexander Simmerl a.simmerl@gmail.com

kim commented 3 years ago

This pattern has been condemned to be frowned upon by Radicle Decision 0002. If we do this anyways, I would request to not use the debug formatter, as defaulting to that (with no option to change it) is basically what makes tracing less-than-useful for logging.

xla commented 3 years ago

@kim I can't really see what 0002 is proposing for a case like the one we have at our hands here. Reckon doesn't hurt to not use Debug formatting.

kim commented 3 years ago

https://github.com/radicle-dev/radicle-decisions/blob/master/proposals/0002.md#the-behavior-of-display:

It should never include information provided by the error returned from the source.