search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

testing: shutdown runtime with timeout #670

Closed kim closed 3 years ago

kim commented 3 years ago

The nested runtime for the git p2p transport appears to cause the global runtime to get stuck on shutdown for not entirely clear reasons (some thread::unpark seems to get lost). Adding a small timeout to keep runaway tasks running seems to fix that, while still preventing blocking tasks to access already-dropped temporary directories.

kim commented 3 years ago

Yeah there’s something else being racy — you’ll also occasionally see an error where the signed refs commit (presumably) either doesn’t have a parent where it expects one, or has one where it doesn’t expect it. On the up side, this is now finally easier to see :)

kim commented 3 years ago

Not sure what's going on with the lint failure -- local clippy is happy with that, and I can't seem to find an incantation which makes it pass.