search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

Frequent advertisements spotted flooding upstream #700

Open viraptor opened 3 years ago

viraptor commented 3 years ago

When I open upstream 0.2.6, I see lots of advertisements flooding in. For example:

 2021-06-12T01:46:37.529 INFO  librad::net::protocol::io::streams                    > new ingress stream 
 2021-06-12T01:46:37.529 INFO  librad::net::protocol::broadcast                      > apply; remote_id=hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc message=Want { origin: GenericPeerInfo { peer_id: hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc, advertised_info: PeerAdvertisement { listen_addrs: Within { inner: [10.164.0.8:12345, 127.0.0.1:12345], _min: PhantomData, _max: PhantomData }, capabilities: {} }, seen_addrs: Within { inner: [], _min: PhantomData, _max: PhantomData } }, val: Payload { urn: Urn { id: Oid(6473a027a10e24148872cda22d67bf831ed32adf), path: Some(RefLike("rad/id")) }, rev: Some(Git(e0ad2de9be92f2f5ea12c71c465307d6f5bed906)), origin: None } }
 2021-06-12T01:46:37.529 INFO  librad::net::protocol::io::streams                    > new ingress stream 
 2021-06-12T01:46:37.530 INFO  librad::net::protocol::broadcast                      > apply; remote_id=hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc message=Want { origin: GenericPeerInfo { peer_id: hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc, advertised_info: PeerAdvertisement { listen_addrs: Within { inner: [10.164.0.8:12345, 127.0.0.1:12345], _min: PhantomData, _max: PhantomData }, capabilities: {} }, seen_addrs: Within { inner: [], _min: PhantomData, _max: PhantomData } }, val: Payload { urn: Urn { id: Oid(6473a027a10e24148872cda22d67bf831ed32adf), path: Some(RefLike("rad/id")) }, rev: Some(Git(e0ad2de9be92f2f5ea12c71c465307d6f5bed906)), origin: None } }
 2021-06-12T01:46:38.347 INFO  librad::net::protocol::io::streams                    > new ingress stream 
 2021-06-12T01:46:38.347 INFO  librad::net::protocol::broadcast                      > apply; remote_id=hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc message=Want { origin: GenericPeerInfo { peer_id: hynkyndc6w3p8urucakobzna7sxwgcqny7xxtw88dtx3pkf7m3nrzc, advertised_info: PeerAdvertisement { listen_addrs: Within { inner: [10.164.0.8:12345, 127.0.0.1:12345], _min: PhantomData, _max: PhantomData }, capabilities: {} }, seen_addrs: Within { inner: [], _min: PhantomData, _max: PhantomData } }, val: Payload { urn: Urn { id: Oid(6473a027a10e24148872cda22d67bf831ed32adf), path: Some(RefLike("rad/id")) }, rev: Some(Git(e0ad2de9be92f2f5ea12c71c465307d6f5bed906)), origin: None } }

There's a chance I'm reading the wrong, but the way I understand it, they're... weird. These are all asking for the same project / commit and milliseconds apart - why is sprout asking for it that often?

(this is only a sample - I'm seeing hundreds of those messages a minute - all with the same info)

PS. Do you want to add an explicit advertised address for sprout? I'm pretty sure nobody connects to it over the loopback ;)