search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
421 stars 39 forks source link

Time out when establishing connection to peers #737

Closed geigerzaehler closed 2 years ago

geigerzaehler commented 2 years ago

Establishing a QUIC connection to a peer should time out when the peer does not respond. This should probably be added to librad::net::protocol::io::connection::connect().

kim commented 2 years ago

Last time I checked, quinn times out connection attempts. Feel free to reopen if you have more info which shows that is not true

geigerzaehler commented 2 years ago

You’re right. I times out, just after more than a minute though. This is why I didn’t see it.

kim commented 2 years ago

I think it is the same timer that is also used for packet loss detection. Not sure if this is mandated by QUIC, or could be a separate tunable.