radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

fetch error: lock file exists #758

Open geigerzaehler opened 3 years ago

geigerzaehler commented 3 years ago

We sometimes see the following errors on CI

fetch error
  urn=rad:git:hnrkycwsgjfsczs3reyjoomhra38h85jo87ky
  remote_peer=hyyf6aqsao5yjcnx49ohi4mkwenrf7dwm5gmmw9kn1a63dagxrqrn6
  error=Replication(Fetch(Git(Error { code: -1, klass: 2, message: "failed to create locked file '/usr/local/var/buildkite-agent/builds/mac-n-cheese-local/monadic/radicle-upstream/cypress/workspace/test-tmp/patches -- updates maintainer view when a patch has been received.9ab5/node-17000/0914c5d2-b619-4268-b0e1-672ab513a704/git/refs/namespaces/hnrkycwsgjfsczs3reyjoomhra38h85jo87ky/refs/remotes/hyyf6aqsao5yjcnx49ohi4mkwenrf7dwm5gmmw9kn1a63dagxrqrn6/tags/radicle-patch/feature-1.lock': File exists" })))

To me it looks like the calls to librad::git::replication::replicate() issued by librad::net::peer::Storage::put as a response to gossip messages and by regular calls to daemon::peer::sync::sync() race.