search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

daemon: remove sync #770

Closed FintanH closed 3 years ago

FintanH commented 3 years ago

With rere and eventually grafting, we will not need the sync mechanism.

Currently we have been deploying seeds with rere disabled, but this makes upgrading less maintainable as we need to keep track of an extra branch. We did this because of some emergent effects between rere and sync, so this also allows us to move forward with rere.

Signed-off-by: Fintan Halpenny fintan.halpenny@gmail.com

kim commented 3 years ago

Hm interesting. Is that the code path which could've been altered as proposed here?

FintanH commented 3 years ago

Hm interesting. Is that the code path which could've been altered as proposed here?

Well, there's also this shouting match https://github.com/radicle-dev/radicle-link/blob/master/daemon/src/peer/announcement.rs#L133-L152 which announces new commits.

I wasn't around when the rere and sync shenanigans were happening, I believe. Maybe @xla could shed some light there if he remembers.