search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
423 stars 39 forks source link

linkd #779

Closed xla closed 3 years ago

xla commented 3 years ago

First iterative implementation of RFC 0696 focusing on driving the core peer protocol and establishing the harness for configuration of a running node. Rite of passage for it was the replacement of the ephemeral peer in the e2e networkss, as that required a well behaved peers with a set of knobs exposed.

Structurally the majority implementation lives in a library crate linkd-lib - probably the most horrendous crate name in this repo to date - with a newly created workspace under bins and a linkd crate in wrapping it lightly in a main. That strategy allows for a checked-in Cargo.lock for binaries associated with link project. Beyond that the code is rather Mario-esque as it is primarily plumbing of code that either existed in other crates backing binaries or newish code doing the same thing for core pieces.

There are still large pieces missing, which a tracked in #722 and will be piled on-top as patches to keep this already big delta focused. The declared initial goal is to get linkd into a state where it can run as bootstrap/seed node.

kim commented 3 years ago

I would, however, appreciate a slightly more condensed commit history.

xla commented 3 years ago

I would, however, appreciate a slightly more condensed commit history.

I always squash before merge but leave that to the latest point to account for commits addressing feedback.