search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
421 stars 39 forks source link

Provide additional information about connected peers #781

Open geigerzaehler opened 2 years ago

geigerzaehler commented 2 years ago

Currently, users of radicle-daemon get information about the connected peers from the Status in the StatusChanged Event. The list set of peers includes peers that the protocol has established a QUIC connection with and that have not responded to the membership protocol yet.

To improve this the daemon should also provide information about the peers in the active and passive sets of the membership protocol so we can display that information.

kim commented 2 years ago

The information provided is objectively accurate, you are asking for additional information. It is more common to phrase such a request as a question accordingly, if you are unsure whether there might be a reason the requested functionality is not present, and offer to provide a patch. Or provide the patch outright if you are assertive.

You are looking for net::peer::Peer::membership exposed from librad. Be aware that it is considered a bug that the return type of net::peer::Peer::stats contains IP addresses.

Thanks.

xla commented 2 years ago

You are looking for net::peer::Peer::membership exposed from librad. Be aware that it is considered a bug that the return type of net::peer::Peer::stats contains IP addresses.

@geigerzaehler If you curious as to why check the first item in #722 with the linked discussion to RFC0696.