search

radicle-dev / radicle-link

The second iteration of the Radicle code collaboration protocol.
Other
421 stars 39 forks source link

make ssh operations sync #796

Open xphoniex opened 1 year ago

xphoniex commented 1 year ago

This PR completes the work done in https://github.com/radicle-dev/radicle-keystore/pull/38.

Once these two PRs are merged, cli tooling can be switched over to sync version with minimal change.

Signed-off-by: xphoniex xphoniex@users.noreply.github.com

FintanH commented 1 year ago

Do you want to fix the build errors before I review?

xphoniex commented 1 year ago

Do you want to fix the build errors before I review?

Hm... I looked into a few of them and they're not cause by my code e.g. this :

error: unnecessary closure used with `bool::then`
  --> git-ref-format/core/src/lit.rs:24:9
   |
24 |         (c.as_ref() == Self::NAME).then(|| Self::SELF)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------
   |                                    |
   |                                    help: use `then_some(..)` instead: `then_some(Self::SELF)`
   |
   = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
FintanH commented 1 year ago

Right, I'm fixing those here https://github.com/radicle-dev/radicle-link/pull/797