radicle-dev / radicle-surf

A code browsing library for VCS file systems.
Other
32 stars 11 forks source link

Use git ext #160

Closed FintanH closed 3 years ago

FintanH commented 3 years ago

The parsing of references in radicle-surf was quite ad-hoc and used regexes. We wish to move to a more disciplined approach by using radicle-git-ext's family of reference structures.

Admittedly, there's still some ad-hoc parsing or removing of prefixes but it's still better than before.

FintanH commented 3 years ago

I think I'd like to move radicle-git-ext into its own publishable crate so that we can have lax version bounds on surf¸ link, and proxy. What do you guys think?

FintanH commented 3 years ago

I think I'd like to move radicle-git-ext into its own publishable crate so that we can have lax version bounds on surf¸ link, and proxy. What do you guys think?

Looking at migrating it to its own repository, there are two things:

kim commented 3 years ago

I can't say I'm keen on this - neither of the *-ext crates is in a state where I'd be happy to stabilise them. If this is only about reference names, I would prefer to maintain a copy of those types + macros for surf over the nightmare that is cargo dependency resolution.

FintanH commented 3 years ago

Ok, I'll copy them over and create a ticket to do a crate migration at some point in the future :+1:

FintanH commented 3 years ago

The duplication has it's own issue while I was carving this out. Gonna drop this until another time and find a different fix.