Closed FintanH closed 3 years ago
I think I'd like to move radicle-git-ext
into its own publishable crate so that we can have lax version bounds on surf¸ link, and proxy. What do you guys think?
I think I'd like to move radicle-git-ext into its own publishable crate so that we can have lax version bounds on surf¸ link, and proxy. What do you guys think?
Looking at migrating it to its own repository, there are two things:
radicle-std-ext
would need to be migrated tooradicle-git-ext
uses librad-test
's json_roundtrip
-- since this isn't librad
specific we could also create a testing crateI can't say I'm keen on this - neither of the *-ext
crates is in a state where I'd be happy to stabilise them. If this is only about reference names, I would prefer to maintain a copy of those types + macros for surf over the nightmare that is cargo
dependency resolution.
Ok, I'll copy them over and create a ticket to do a crate migration at some point in the future :+1:
The duplication has it's own issue while I was carving this out. Gonna drop this until another time and find a different fix.
The parsing of references in radicle-surf was quite ad-hoc and used regexes. We wish to move to a more disciplined approach by using radicle-git-ext's family of reference structures.
Admittedly, there's still some ad-hoc parsing or removing of prefixes but it's still better than before.