search

radicle-dev / radicle-surf

A code browsing library for VCS file systems.
Other
32 stars 11 forks source link

`BranchSelector` enum #181

Closed therealyingtong closed 3 years ago

therealyingtong commented 3 years ago

Closes #142.

FintanH commented 3 years ago

Hey @therealyingtong :wave: thanks for the contribution! :blush: As per our DCO, we require that you sign-off all your commits. Let me know if you need help with this :)

therealyingtong commented 3 years ago

Might a similar refactor (Option<BranchType> -> BranchSelector) be valuable in radicle-upstream?

https://github.com/radicle-dev/radicle-upstream/blob/master/proxy/coco/src/source.rs#L552

FintanH commented 3 years ago

Might a similar refactor (Option -> BranchSelector) be valuable in radicle-upstream?

That's not necessary. This code is currently duplicated while we move some things around. This PR https://github.com/radicle-dev/radicle-upstream/pull/1753 will resolve this for us.

FintanH commented 3 years ago

Thanks @therealyingtong! :blush: