Closed geigerzaehler closed 3 years ago
I beg to differ :upside_down_face: https://github.com/radicle-dev/radicle-surf/pull/194
Could it be the case that this happens when we're under a namespace?
BranchSelector::All
. This uses **
as the remote in the glob refs/namespaces/<ns>/**/*
. And this coincidentally matches all branches. If we use BranchSelector::Remote
(like we do in upstream) branches with slashes are not listed. I created a failing test case in #195.Ah perfect, thanks for creating the failing case!
I believe it might actually be a parsing issue in the TryFrom
impl for Branch
False alarm. This does actually work: https://github.com/radicle-dev/radicle-surf/blob/eff4cf3d9685f9eb051c864c00b62bbeb21da7a9/surf/src/vcs/git.rs#L1218-L1221
Seems like me problem originated from somewhere else.
Assume we have a repo with the following ref:
refs/remotes/banana/orange/lemon
. I’d expectorange/lemon
to be included in the result ofThe current behavior is that
orange/lemon
is not included.The culprit is the single star glob
*
at the end here. Changing this to a double-start glob is not straight-forward though. This would also mean that the internalrad/self
branches are listed byradicle-source
.