search

radicle-dev / radicle-surf

A code browsing library for VCS file systems.
Other
32 stars 11 forks source link

surf: Add failing tests for branch with slashes #195

Closed geigerzaehler closed 3 years ago

FintanH commented 3 years ago

@geigerzaehler actually you were just missing an expectation case for the test :grimacing: Everything seems to work fine, so perhaps it is the namespacing that's causing the issue you see?

geigerzaehler commented 3 years ago

You’re right :see_no_evil:. I don’t know what caused the issue when I was working on it. Maybe I didn’t update the repo refs correctly. I was also able to track down some definitive documentation on globs which confirms that * matches any sequence of characters including /.

FintanH commented 3 years ago

Well, let's at least rebase this and merge it so we have these test cases :) If you want to try adding a case using a namespace and listing a particular remote that should make sure that our bases are covered. Otherwise, I guess I'll wait for you to find this mysterious bug again :P

geigerzaehler commented 3 years ago

And this is already covered by the tests :facepalm:: https://github.com/radicle-dev/radicle-surf/blob/eff4cf3d9685f9eb051c864c00b62bbeb21da7a9/surf/src/vcs/git.rs#L1218-L1221