search

radicle-dev / radicle-surf

A code browsing library for VCS file systems.
Other
32 stars 11 forks source link

Add diffs for created and deleted files #203

Closed rudolfs closed 2 years ago

rudolfs commented 2 years ago

We'd like to show the file contents for created and deleted files when reviewing code, otherwise we can't do full review within our app.

Here's how it looks in Upstream:

Screenshot 2022-06-07 at 10 51 15
rudolfs commented 2 years ago

I wasn't sure whether we need the missing EOF for new and deleted files, hence left it out for now.

cloudhead commented 2 years ago

Nice!

geigerzaehler commented 2 years ago

Looks good from my perspective. Just need to fix the lints

rudolfs commented 2 years ago

Just need to fix the lints

@geigerzaehler fixed the lints. cargo-deny is also failing on master. 🤷